[ci] Script for building M1 wheels #19925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR includes a script for building wheels for Macs with M1 processors. It roughly follows the pattern of the other scripts with a few differences. * Manually installs `nvm` * Uses miniforge conda to install python/pip instead of python foundation .pkgs * Doesn't pin numpy (we probably shouldn't be pinning it in the other scripts either...) * Commit detection falls back to `git` instead of erroring All of these changes were made so that the script works on a laptop, which comes with a subset of the dependencies that the x86 buildkite image comes with.
|
@gjoliver this script works on my laptop, it would be great to make sure that it works on at least one other machine (i.e. yours). |
gjoliver
approved these changes
Nov 1, 2021
python/build-wheel-macos-m1.sh
Outdated
| @@ -84,7 +79,6 @@ for ((i=0; i<${#PY_VERSIONS[@]}; ++i)); do | |||
| TRAVIS_COMMIT=$(git rev-parse HEAD) | |||
| fi | |||
|
|
|||
| echo $TRAVIS_COMMIT | |||
There was a problem hiding this comment.
oh i mean i guess we could, it was just an accidental debugging print statement i left in.
(note we are already printing echo "TRAVIS_COMMIT variable detected. ray.__commit__ will be set to $TRAVIS_COMMIT")
|
also, maybe we should rename the script to build-wheel-macos-arm64.sh |
simon-mo
added
the
@author-action-required
|
leaving up to @wuisawesome to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR includes a script for building wheels for Macs with M1 processors. It roughly follows the pattern of the other scripts with a few differences.
nvmgitinstead of erroringAll of these changes were made so that the script works on a laptop, which comes with a subset of the dependencies that the x86 buildkite image comes with.
Related issue number
Checks
scripts/format.shto lint the changes in this PR.